Responsive Banner Slider is incorrectly using hardcoded element IDs.
- Posted by Frank Mayer (3) Offline
Hello,
Responsive Banner Slider is incorrectly using hardcoded element IDs.
An element reference should only be used once. In the case of multiple modules on the same page, those are referenced multiple times, which is wrong and may introduce conflicts. For example those three divs:
This is with version 2.2.5
10 years 2 weeks ago #1
by Frank Mayer
Responsive Banner Slider is incorrectly using hardcoded element IDs.
An element reference should only be used once. In the case of multiple modules on the same page, those are referenced multiple times, which is wrong and may introduce conflicts. For example those three divs:
<div id="responsive-banner-slider" class="rbs-313">
<div id="viewport-shadow">
<div id="viewport">
This is with version 2.2.5
Please Log in or Create an account to join the conversation.
- Posted by Frank Mayer (3) Offline
the code tags ate the code example!! heres the code again (hopefully):
<div id="responsive-banner-slider" class="rbs-313">
<div id="viewport-shadow">
<div id="viewport">
10 years 2 weeks ago #2
by Frank Mayer
<div id="responsive-banner-slider" class="rbs-313">
<div id="viewport-shadow">
<div id="viewport">
<div id="responsive-banner-slider" class="rbs-313">
<div id="viewport-shadow">
<div id="viewport">
Please Log in or Create an account to join the conversation.
- Posted by TemplatePlazza (5310) Offline
Hi tsm, sorry for delay in responding. Yes we're aware of it but unfortunately the fix id name is needed by the javascript file.
10 years 2 weeks ago #3
by TemplatePlazza
Please Log in or Create an account to join the conversation.